Exception based scheduling #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@binh-dam-ibigroup before i dive into a fix (to replace the temp fix that doesn't work) do you have any thoughts on how to approach this which might save me a bit of time?! |
There was a problem hiding this comment.
@br648 I think this is headed in the right direction! (Add the tests for checking that the logic works.)
src/main/java/com/conveyal/datatools/manager/jobs/feedmerge/MergeLineContext.java
Outdated
Show resolved
Hide resolved
| "%s:%s:%s", | ||
| table.name, | ||
| field.name, | ||
| field.referenceTables.stream().map(r -> r.name).collect(Collectors.joining(":")) |
There was a problem hiding this comment.
Hopefully we don't rely extract values from keys by relying on the ":" separator.
There was a problem hiding this comment.
I've made changes to this in my latest update to use a more unque key.
…dle multi ref tables
binh-dam-ibigroup
approved these changes
Jul 10, 2023
src/main/java/com/conveyal/datatools/manager/jobs/feedmerge/ReferenceTableDiscovery.java
Outdated
Show resolved
Hide resolved
|
@br648 Remember to address the merge conflict. |
5 tasks
added 2 commits
August 21, 2023 08:41
philip-cline
approved these changes
Aug 23, 2023
5 tasks
|
Awaiting #567 to be merged |
key now includes reference to schedule exceptions matching trip service_id references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR includes the exception based scheduling updates made to GTFS-lib (conveyal/gtfs-lib#385) and a rector of feed merge to accommodate multiple table references.