-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MobilityData GTFS Validator to validation step #512
Conversation
2ca035d
to
9be044a
Compare
0d466a3
to
955b74c
Compare
…xecuted in separate threads
@miles-grant-ibigroup for review: #513. We should discuss at some point next week. |
@miles-grant-ibigroup I'm going to defer my review until this #513 is tested and merged. |
Updated Geo Tools
…of feed version in relation to
…alidateMobilityDataFeedJob fail
Threaded validation
src/main/java/com/conveyal/datatools/manager/models/transform/NormalizeFieldTransformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java
Outdated
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java
Outdated
Show resolved
Hide resolved
Thanks Rob! All changes have been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Good luck presenting the new data!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, seems to work well.
Checklist
dev
before they can be merged tomaster
)Description
This PR integrates the MobilityData GTFS Validator into datatools, and adds a MobilityData validation to the GTFS validation step. Validation results are saved to a unique temporary folder, then loaded and inserted into Mongo. Failures are handled via the existing validation failure infrastructure.
Room for Improvement
Important Notices
The MobilityData validator requires a much newer version of the Java spec. I've updated by JDK to 18, and language level to 11!
Tests are failing due to an unrelated shape file export issue