adds more specific smoke tests to be used on local deployments #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
force-pushed
the
add-deployment-smoke-test
branch
from
db6dd5c
to
cb998dd
Compare
|
This is early days but I think you want to separate these from the other smoke tests which test really that there are no regressions in the OTP code. You could either move them to a new repo or at least into a new workflow that runs on a schedule. |
|
Yeah, they are definitely a separate "thing" from the other smoke tests. Should we pull out my assertion code + some of your helpers into a separate library? Putting these tests alongside OTP in our fork does feel a bit weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main goal of this PR is to build more smoke tests to be run against local deployments to ensure all the feeds exist, have correct data, etc. As part of this I'm building a more robust system for the assertions.