feat(hl): Add new FzfLuaPreviewBorder highlight

[mikesmithgh]

I'd like to add an additional highlight group FzfLuaPreviewBorder. I have different background colors for the fzf window and preview window. This allows me to customize the border on each differently to match the corresponding background color.

Without the highlight group:

With the highlight group:

Please let me know what you think.

[ibhagwan]

Merged, tysm for the contribution @mikesmithgh!

[nyngwang]

I tried hi FzfLuaPreviewBorder guibg=red guifg=red but I didn't see any change.

[ibhagwan]

74da5c5

FYI , the above commit also adds FzfLuaPreviewNormal to make it more consistent and not have to use winopts.preview.winopts to set the previewer window highlights.

I tried hi FzfLuaPreviewBorder guibg=red guifg=red but I didn't see any change.

@nyngwang, checking.

[ibhagwan]

@nyngwang, try a2dcd45, just tested with:

:hi! link FzfLuaPreviewNormal NvimInternalError

[nyngwang]

@ibhagwan Now it works. I just tested the same command and the color can be changed dynamically :) Thank you!

[nyngwang]

@ibhagwan I found that the same problem occurs on FzfLuaTabTitle:

1. No effect, if using :FzfLua tabs to call it.
2. Cannot be changed after Neovim has been started, if using :lua require('fzf-lua').tabs with tab_title being overridden:

   vim.keymap.set('n', '<C-b>', function () require('fzf-lua').tabs {
     tab_title = {
       function (tab_idx, is_current)
       end,
       'FzfLuaTabTitle',
     },
   } end)

[ibhagwan]

@nyngwang, there is no FzfLuaTabTitle highlight in the code, if this is a different issue related to the customization of tab highlights let's open a new issue for this?

[nyngwang]

You're right. I just realized that it is my custom highlight group for the titles of :FzfLua tabs.

[nyngwang]

@ibhagwan 6b1f32d seems to break it, i.e. the highlight groups FzfLuaPreviewBorder, FzfLuaBorder, FzfLuaTitle set by my colorscheme are all ignored.

[ibhagwan]

@ibhagwan 6b1f32d seems to break it, i.e. the highlight groups FzfLuaPreviewBorder, FzfLuaBorder, FzfLuaTitle set by my colorscheme are all ignored.

@nyngwang, update to 2803904, should work again unless you're using neovim 0.8.x.

[nyngwang]

Confirmed, thank you!