Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8140: Enabled authenticator manager-based security #90

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented May 9, 2024

🎫 Issue IBX-8140

Introduced changes for now circle around allowing users to perform authorization process at all. The whole REST authorization needs to be revisited in the next steps.

First and foremost we most likely need another firewall for rest authorization as current overrides remove check_path which made debugging the whole built-in authorization way harder. Registering another REST-specific firewall is done via Security/RestSessionBasedFactory.php::createAuthenticator method for now.

Related PRs:

Description:

For QA:

Documentation:

@konradoboza konradoboza force-pushed the ibx-8140-enable-authorization-with-new-authenticator-mechanisms branch from 5229e9c to 8c8fcca Compare May 10, 2024 07:52
@konradoboza konradoboza marked this pull request as ready for review May 14, 2024 11:58
@konradoboza konradoboza added Feature New feature request Ready for review labels May 14, 2024
@konradoboza konradoboza requested a review from a team May 14, 2024 13:51
@konradoboza konradoboza force-pushed the ibx-8140-enable-authorization-with-new-authenticator-mechanisms branch from 8c8fcca to af652e4 Compare May 20, 2024 10:38
@konradoboza
Copy link
Contributor Author

Failing CI is addressed here: #93.

@konradoboza konradoboza force-pushed the ibx-8140-enable-authorization-with-new-authenticator-mechanisms branch from af652e4 to 9b689a2 Compare May 20, 2024 12:44
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz requested a review from a team May 21, 2024 10:29
@konradoboza konradoboza requested a review from a team May 22, 2024 07:05
@konradoboza konradoboza merged commit ff2002f into main May 23, 2024
9 checks passed
@konradoboza konradoboza deleted the ibx-8140-enable-authorization-with-new-authenticator-mechanisms branch May 23, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants