IBX-8140: Enabled authenticator manager-based security #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2024
konradoboza
force-pushed
the
ibx-8140-enable-authorization-with-new-authenticator-mechanisms
branch
from
5229e9c
to
8c8fcca
Compare
konradoboza
force-pushed
the
ibx-8140-enable-authorization-with-new-authenticator-mechanisms
branch
from
8c8fcca
to
af652e4
Compare
|
Failing CI is addressed here: #93. |
This was referenced May 20, 2024
konradoboza
force-pushed
the
ibx-8140-enable-authorization-with-new-authenticator-mechanisms
branch
from
af652e4
to
9b689a2
Compare
|
adamwojs
approved these changes
May 21, 2024
alongosz
approved these changes
May 21, 2024
Nattfarinn
approved these changes
May 22, 2024
Steveb-p
approved these changes
May 22, 2024
konradoboza
deleted the
ibx-8140-enable-authorization-with-new-authenticator-mechanisms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced changes for now circle around allowing users to perform authorization process at all. The whole REST authorization needs to be revisited in the next steps.
First and foremost we most likely need another firewall for rest authorization as current overrides remove
check_pathwhich made debugging the whole built-in authorization way harder. Registering another REST-specific firewall is done viaSecurity/RestSessionBasedFactory.php::createAuthenticatormethod for now.Related PRs:
Description:
For QA:
Documentation: