Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7653: Add FilterParser and IsContainer criterion parser #84

Merged
merged 11 commits into from
May 16, 2024
Merged

IBX-7653: Add FilterParser and IsContainer criterion parser #84

merged 11 commits into from
May 16, 2024

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Feb 12, 2024 •
edited
Loading

🎫 Issue IBX-7653

Related PRs:

Description:

For QA:

Documentation:

@tischsoic tischsoic self-assigned this Feb 12, 2024
@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from 196b96d to 0dcf440 Compare February 22, 2024 08:38
@tischsoic
Copy link
Contributor Author

Depends on other PR, regression run in: ibexa/commerce#701

@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from 4de0946 to 07c0cf8 Compare February 22, 2024 10:45
@tischsoic tischsoic marked this pull request as ready for review February 22, 2024 11:27
@tischsoic tischsoic requested a review from a team February 22, 2024 11:29
@tischsoic tischsoic changed the base branch from main to 4.6 March 25, 2024 10:18
@Steveb-p Steveb-p requested a review from a team April 4, 2024 12:25
@konradoboza konradoboza requested a review from a team April 4, 2024 12:28
adamwojs
adamwojs approved these changes Apr 5, 2024
View reviewed changes
src/bundle/Resources/config/input_parsers.yml Outdated Show resolved Hide resolved
src/lib/Server/Input/Parser/Criterion/IsContainer.php Outdated Show resolved Hide resolved
@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from 02e03b3 to 980cd9a Compare April 18, 2024 10:01
This was referenced May 10, 2024
Closed
Closed
Closed
@tischsoic tischsoic force-pushed the IBX-7653-images-visible-in-tree-browser-in-image-picker branch from 5943c74 to a3d5a27 Compare May 16, 2024 07:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tischsoic
Copy link
Contributor Author

CI is failing because [TMP] commits have been removed.

@dew326 dew326 merged commit 8df1859 into 4.6 May 16, 2024
8 of 12 checks passed
@dew326 dew326 deleted the IBX-7653-images-visible-in-tree-browser-in-image-picker branch May 16, 2024 07:21
@tischsoic
Copy link
Contributor Author

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@bogusez bogusez bogusez approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tischsoic @adamwojs @Steveb-p @alongosz @ViniTou @konradoboza @bogusez @dew326