Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7418: Added input parser for ContentName criterion #82

Merged
merged 2 commits into from
Jan 17, 2024
Merged

IBX-7418: Added input parser for ContentName criterion #82

merged 2 commits into from
Jan 17, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Dec 20, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-7418
Type feature
Target version Ibexa DXP v4.6
BC breaks no
Tests pass yes
Doc needed yes
Related PRs ibexa/core#312, ibexa/solr#61, https://github.com/ibexa/elasticsearch/pull/34

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ciastektk ciastektk added Feature New feature request Ready for review labels Dec 20, 2023
@ciastektk ciastektk requested a review from a team December 20, 2023 13:56
konradoboza
konradoboza approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from failing CI and missing tests.

@konradoboza konradoboza requested a review from a team December 21, 2023 07:26
@alongosz alongosz force-pushed the ibx-7418-added-input-parser-for-content-name-criterion branch from 9c0abf9 to d859335 Compare December 21, 2023 13:08
@ciastektk ciastektk force-pushed the ibx-7418-added-input-parser-for-content-name-criterion branch from 1b8acbf to 3d4dad4 Compare December 22, 2023 11:34
@ciastektk ciastektk force-pushed the ibx-7418-added-input-parser-for-content-name-criterion branch 2 times, most recently from 7206904 to ae4b959 Compare December 22, 2023 14:04
@ciastektk ciastektk force-pushed the ibx-7418-added-input-parser-for-content-name-criterion branch from ae4b959 to 8f1d661 Compare January 8, 2024 07:39
@ciastektk ciastektk force-pushed the ibx-7418-added-input-parser-for-content-name-criterion branch from 8f1d661 to 3c6eb7e Compare January 8, 2024 07:49
This was referenced Jan 12, 2024
Merged
Merged
tomaszszopinski
tomaszszopinski approved these changes Jan 17, 2024
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@ciastektk ciastektk force-pushed the ibx-7418-added-input-parser-for-content-name-criterion branch from 3c6eb7e to 548bbd4 Compare January 17, 2024 13:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 2d69c56 into main Jan 17, 2024
12 checks passed
@alongosz alongosz deleted the ibx-7418-added-input-parser-for-content-name-criterion branch January 17, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Feature New feature request QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ciastektk @webhdx @konradoboza @tomaszszopinski @Steveb-p @alongosz @ViniTou