Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6937: Changed expected min and max value types to numeric for FileSize criterion #81

Merged
merged 1 commit into from
Jan 5, 2024
Merged

IBX-6937: Changed expected min and max value types to numeric for FileSize criterion #81

merged 1 commit into from
Jan 5, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Dec 12, 2023 •
edited by webhdx
Loading

Question Answer
JIRA issue IBX-6937
Type improvement
Target version v4.6
BC breaks no
Tests pass yes
Doc needed yes

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ciastektk ciastektk requested a review from a team December 12, 2023 12:27
@konradoboza konradoboza requested a review from a team December 12, 2023 14:54
@micszo micszo self-assigned this Jan 3, 2024
@micszo micszo mentioned this pull request Jan 3, 2024
Closed
@micszo micszo removed their assignment Jan 5, 2024
@webhdx webhdx force-pushed the ibx-6937-adjusted-file-size-criterion branch from 9dda8b9 to 2c520e8 Compare January 5, 2024 08:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@webhdx webhdx merged commit 93710f1 into main Jan 5, 2024
12 checks passed
@webhdx webhdx deleted the ibx-6937-adjusted-file-size-criterion branch January 5, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ciastektk @Nattfarinn @micszo @konradoboza @Steveb-p @alongosz @webhdx @ViniTou