Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed test after merge-up from 3.3 #74

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fixed test after merge-up from 3.3 #74

merged 1 commit into from
Sep 20, 2023

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Sep 20, 2023

Question Answer
JIRA issue
Type improvement
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

This PR provides a quick fix to Image Variation test.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kisztof kisztof requested a review from a team September 20, 2023 13:05
@alongosz alongosz merged commit 094073f into 4.5 Sep 20, 2023
12 checks passed
@alongosz alongosz deleted the fixed-tests-after-3.3-mergeup branch September 20, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kisztof @alongosz @ciastektk @Steveb-p @ViniTou