Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHPStan #69

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Added PHPStan #69

merged 5 commits into from
Aug 16, 2023

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue N/A
Type improvement
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

This PR adds default PHPStan setup.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@Steveb-p Steveb-p changed the base branch from main to 4.5 August 14, 2023 09:49
@Steveb-p Steveb-p requested a review from a team August 14, 2023 11:54
konradoboza
konradoboza approved these changes Aug 16, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team August 16, 2023 06:10
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou merged commit 14c2394 into 4.5 Aug 16, 2023
12 checks passed
@ViniTou ViniTou deleted the phpstan branch August 16, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steveb-p @ViniTou @konradoboza @alongosz