Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5387: Handled not accessible Location in RelationProcessor #60

Merged
merged 4 commits into from
Apr 12, 2023
Merged

IBX-5387: Handled not accessible Location in RelationProcessor #60

merged 4 commits into from
Apr 12, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Mar 31, 2023

Question Answer
JIRA issue IBX-5387
Type bug
Target version v4.4
BC breaks no
Tests pass yes
Doc needed no

As the title states.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 added Bug Something isn't working Ready for review labels Mar 31, 2023
@barw4 barw4 requested a review from a team March 31, 2023 12:21
@barw4 barw4 self-assigned this Mar 31, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@barw4 barw4 requested review from ViniTou and a team March 31, 2023 13:53
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team March 31, 2023 14:13
adamwojs
adamwojs approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with assumption that this behaviour is consistent with rest of the system

tomaszszopinski
tomaszszopinski approved these changes Apr 12, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved n Ibexa DXP commerce 4.4

@ViniTou ViniTou merged commit 2faca6e into 4.4 Apr 12, 2023
@ViniTou ViniTou deleted the ibx-5387-handle-not-accessible-location-relation-processor branch April 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@ViniTou ViniTou ViniTou approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

@barw4 barw4

Labels
Bug Something isn't working QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barw4 @adamwojs @ViniTou @tomaszszopinski @Steveb-p @alongosz