[TMP] IBX-8535: Dropped deprecated loadRelations usage #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
force-pushed
the
ibx-8535-deprecations
branch
2 times, most recently
from
8a93e9b
to
6af61be
Compare
ViniTou
force-pushed
the
ibx-8535-deprecations
branch
3 times, most recently
from
af470bc
to
9c0faa8
Compare
ViniTou
force-pushed
the
ibx-8535-deprecations
branch
from
9c0faa8
to
9dc3e52
Compare
ViniTou
force-pushed
the
ibx-8535-deprecations
branch
from
3e72a07
to
98e6742
Compare
ViniTou
changed the title
|
alongosz
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Looks overall ok, but remarks from ibexa/core#444 (review) are quite relevant for this.
| @@ -115,7 +117,7 @@ protected function internalGetVisitor() | |||
| { | |||
| return new ValueObjectVisitor\RestExecutedView( | |||
| $this->getLocationServiceMock(), | |||
| $this->getContentServiceMock(), | |||
| new RelationListHelper($this->getContentServiceMock()) | |||
There was a problem hiding this comment.
So... rather mock it here and unit-test in ibexa/core, as reviewed in ibexa/core#444 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For QA:
Documentation: