Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMP] IBX-8535: Dropped deprecated loadRelations usage #137

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 25, 2024

🎫 Issue IBX-8535

Related PRs:

Description:

For QA:

Documentation:

@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch 2 times, most recently from 8a93e9b to 6af61be Compare October 28, 2024 12:21
@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch 3 times, most recently from af470bc to 9c0faa8 Compare October 28, 2024 13:35
@ViniTou ViniTou changed the title IBX-8535: Dropped deprecated loadRelations usage [TMP] IBX-8535: Dropped deprecated loadRelations usage Oct 30, 2024
Copy link

sonarcloud bot commented Oct 30, 2024

@ViniTou ViniTou requested a review from a team October 30, 2024 15:27
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall ok, but remarks from ibexa/core#444 (review) are quite relevant for this.

@@ -115,7 +117,7 @@ protected function internalGetVisitor()
{
return new ValueObjectVisitor\RestExecutedView(
$this->getLocationServiceMock(),
$this->getContentServiceMock(),
new RelationListHelper($this->getContentServiceMock())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... rather mock it here and unit-test in ibexa/core, as reviewed in ibexa/core#444 (review)

@alongosz alongosz requested a review from a team October 30, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants