IBX-8224: Added rector rule to remove interface & methods implementations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
force-pushed
the
ibx-8224-drop-interface-with-methods
branch
2 times, most recently
from
e593e4f
to
db39f2e
Compare
ViniTou
force-pushed
the
ibx-8224-drop-interface-with-methods
branch
from
db39f2e
to
f4b8e49
Compare
alongosz
approved these changes
Jun 17, 2024
adamwojs
approved these changes
Jun 17, 2024
| // Remove method calls, if one of the arguments was removed method | ||
| foreach ($node->getMethods() as $classMethod) { | ||
| $nodeTraverser = new NodeTraverser(); | ||
| $nodeTraverser->addVisitor(new class($this->nodeNameResolver, $methods) extends NodeVisitorAbstract { |
There was a problem hiding this comment.
Can we extract this class to separate file? This would improve a readability a lot.
konradoboza
reviewed
Jun 18, 2024
.../lib/Rule/Internal/RemoveInterfaceWithMethods/Fixture/class_with_removed_method_call.php.inc
Show resolved
Hide resolved
.../lib/Rule/Internal/RemoveInterfaceWithMethods/Fixture/class_with_removed_method_call.php.inc
Show resolved
Hide resolved
ViniTou
force-pushed
the
ibx-8224-drop-interface-with-methods
branch
from
6e3bb1e
to
f4d9f5f
Compare
konradoboza
approved these changes
Jun 18, 2024
alongosz
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: