Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #145

wants to merge 3 commits into from

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Oct 17, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-145

before executing the recipes.

@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 2 times, most recently from c703e9b to 1b96d0c Compare October 18, 2024 10:37
This was referenced Oct 18, 2024
Open
Open
@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 10 times, most recently from acf0af3 to 12fc955 Compare October 22, 2024 08:34
GrabowskiM
GrabowskiM requested changes Oct 25, 2024
View reviewed changes
ibexa/commerce/4.6/encore/package.json Outdated
"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should install this package using specific tag (which currently doesn't exist probably), to avoid problems with updating config in the future.

This comment is valid for all other places as well, of course. :)

@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 4 times, most recently from 7623ba9 to 66bde2b Compare November 12, 2024 13:42
@lucasOsti lucasOsti mentioned this pull request Nov 18, 2024
Open
@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 2 times, most recently from 071c6b3 to eb2b49a Compare November 20, 2024 07:45
GrabowskiM
GrabowskiM requested changes Nov 20, 2024
View reviewed changes
ibexa/oss/5.0/encore/package.json Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozatko bozatko bozatko approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasOsti @GrabowskiM @tischsoic @dew326 @bozatko