Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discounts base recipe #144

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Discounts base recipe #144

merged 2 commits into from
Oct 6, 2024

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Oct 3, 2024

🎫 Issue IBX-XXXXX

Description:

For QA:

Documentation:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-144

before executing the recipes.

@konradoboza konradoboza requested review from adamwojs and a team October 3, 2024 11:05
konradoboza
konradoboza approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after internal sync.

@Steveb-p Steveb-p marked this pull request as ready for review October 3, 2024 11:13
@konradoboza konradoboza requested a review from a team October 3, 2024 11:14
@ciastektk ciastektk requested a review from a team October 3, 2024 11:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs merged commit 3460a12 into master Oct 6, 2024
2 checks passed
@adamwojs adamwojs deleted the discounts branch October 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ciastektk ciastektk ciastektk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steveb-p @adamwojs @ciastektk @konradoboza