Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8482: Fixed lack of JWT stateless calls recognition #125

Merged
merged 3 commits into from
Jul 2, 2024
Merged

IBX-8482: Fixed lack of JWT stateless calls recognition #125

merged 3 commits into from
Jul 2, 2024

Conversation

konradoboza
Copy link
Contributor

🎫 Issue IBX-8482

Description:

It seems stateless calls involving REST and JWT were not properly validated. To be able to do that, we need to have two separate firewalls like suggested in https://symfony.com/bundles/LexikJWTAuthenticationBundle/current/index.html#symfony-5-3-and-higher.

For QA:

Documentation:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-125

before executing the recipes.

@konradoboza konradoboza self-assigned this Jul 1, 2024
@konradoboza konradoboza added Bug Something isn't working Ready for review labels Jul 1, 2024
@konradoboza konradoboza mentioned this pull request Jul 1, 2024
Merged
@konradoboza konradoboza requested a review from a team July 1, 2024 12:59
@micszo micszo changed the title IBX-8482: Fixed lack of JWT stateless calls recognition [TMP commit] IBX-8482: Fixed lack of JWT stateless calls recognition Jul 1, 2024
This was referenced Jul 1, 2024
Closed
Closed
Closed
Closed
@webhdx webhdx requested a review from a team July 2, 2024 09:22
@konradoboza konradoboza requested a review from Steveb-p July 2, 2024 09:23
Steveb-p
Steveb-p approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate it.

LGTM.

:)

@micszo
Revert "[tmp] enable"
2c9935e 
This reverts commit a88f092.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza merged commit 427eff2 into master Jul 2, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-8482-fixed-missing-jwt-calls-recognition branch July 2, 2024 12:57
@konradoboza konradoboza added the Doc needed The changes require some documentation label Jul 3, 2024
@konradoboza konradoboza changed the title [TMP commit] IBX-8482: Fixed lack of JWT stateless calls recognition IBX-8482: Fixed lack of JWT stateless calls recognition Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@webhdx webhdx webhdx approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@konradoboza konradoboza

Labels
Bug Something isn't working Doc needed The changes require some documentation QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@konradoboza @Steveb-p @webhdx @micszo