Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8290: Reworked REST authentication to comply with the new Symfony authenticator mechanism under separate firewall #121

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented May 28, 2024

🎫 Issue IBX-8290

Related PRs:

Description:

REST API authorization should be handled by its own security firewall. This PR aims to add it as the one prior to ibexa_front to be sure only REST requests are matched.

For QA:

Documentation:

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-121

before executing the recipes.

@konradoboza konradoboza changed the title IBX-8290: Reworked REST authentication to comply with the authenticator mechanism under separate firewall IBX-8290: Reworked REST authentication to comply with the new Symfony authenticator mechanism under separate firewall May 28, 2024
@konradoboza konradoboza force-pushed the ibx-8290-re-implement-rest-auth branch from f8934f3 to 17b1e4d Compare May 29, 2024 07:19
@konradoboza konradoboza marked this pull request as ready for review June 3, 2024 13:28
@konradoboza konradoboza added the Feature New feature request label Jun 4, 2024
@konradoboza konradoboza self-assigned this Jun 4, 2024
@konradoboza konradoboza requested a review from a team June 4, 2024 12:15
@konradoboza konradoboza force-pushed the ibx-8290-re-implement-rest-auth branch 2 times, most recently from 492eb54 to d2ea5fc Compare June 5, 2024 11:28
@konradoboza konradoboza force-pushed the ibx-8290-re-implement-rest-auth branch from d2ea5fc to 29858ef Compare June 5, 2024 11:37
@alongosz alongosz requested a review from a team June 7, 2024 17:29
Copy link

sonarcloud bot commented Jun 20, 2024

@konradoboza
Copy link
Contributor Author

Added security context (ref: https://symfony.com/doc/5.x/reference/configuration/security.html#firewall-context) which allows to share session between firewalls. It resolves issue with access to some endpoints within BO as REST resides under separate firewall in the new configuration.

@micszo micszo removed their assignment Jun 20, 2024
@konradoboza konradoboza merged commit 53e9df8 into master Jun 20, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-8290-re-implement-rest-auth branch June 20, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants