-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2355: Made inheritance of the naming methods possible #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
approved these changes
Mar 28, 2022
adamwojs
approved these changes
Mar 28, 2022
IMHO it's worth to consider extracting interface from NameHelper but this could be done as follow up. |
konradoboza
force-pushed
the
ibx-2355-improved-name-helper-inheritance
branch
from
March 28, 2022 14:04
2d2a0df
to
b377ddf
Compare
bdunogier
approved these changes
Mar 28, 2022
bdunogier
reviewed
Mar 28, 2022
konradoboza
force-pushed
the
ibx-2355-improved-name-helper-inheritance
branch
from
March 28, 2022 15:43
b377ddf
to
0ab6bcb
Compare
adamwojs
approved these changes
Mar 29, 2022
konradoboza
force-pushed
the
ibx-2355-improved-name-helper-inheritance
branch
from
March 29, 2022 10:53
b22ca14
to
149c00a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-2355
In order to reuse methods
pluralize
andtoCamelCase
within https://github.com/ibexa/product-catalog/pull/456 we need to change their scope to be able to decorate the original implementation and avoid redundancy.