Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8875: Dropped deprecated code #185

Merged
merged 7 commits into from
Sep 28, 2024
Merged

IBX-8875: Dropped deprecated code #185

merged 7 commits into from
Sep 28, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Sep 17, 2024 •
edited
Loading

🎫 Issue IBX-8875

Description:

For QA:

Regression build

Documentation:

  • Dropping OnlineEditorCustomAttributesExtractor does not affect end-users and end-developers.
  • If stored RichText contains any not configured / unknown custom tag, then when saving such content item, it will result in a validation error.

@alongosz alongosz marked this pull request as draft September 18, 2024 09:55
@alongosz alongosz force-pushed the ibx-8875-richtext-deprecations-removal branch 2 times, most recently from 53518ce to eedbdf8 Compare September 18, 2024 11:08
@alongosz
Defined Xslt::$xsltProcessor property so it's not dynamic
9ee0bcb 
Creation of dynamic property Ibexa\FieldTypeRichText\RichText\Converter\Xslt::$xsltProcessor is deprecated
@alongosz
Improved quality of Xslt Converter implementation
837f771
@alongosz
Dropped deprecated support for not configured custom tag
cd2e648 
CustomTagsValidator will now return a validation error when a document contains not configured custom tag
@alongosz
Improved CustomTagsValidator class code quality
7044bbc
@alongosz alongosz force-pushed the ibx-8875-richtext-deprecations-removal branch from eedbdf8 to d2c743c Compare September 18, 2024 13:05
@alongosz alongosz marked this pull request as ready for review September 18, 2024 13:06
@alongosz alongosz force-pushed the ibx-8875-richtext-deprecations-removal branch from d2c743c to c61368d Compare September 18, 2024 13:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz mentioned this pull request Sep 20, 2024
Closed
@alongosz alongosz added Doc needed The changes require some documentation Improvement labels Sep 20, 2024
@adamwojs adamwojs merged commit 1d7a8da into main Sep 28, 2024
16 checks passed
@adamwojs adamwojs deleted the ibx-8875-richtext-deprecations-removal branch September 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@alongosz alongosz

@konradoboza konradoboza

Labels
Doc needed The changes require some documentation Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alongosz @adamwojs @konradoboza