Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6200: Changed the was custom styles list is diplayed #109

Merged
merged 1 commit into from
Aug 1, 2023
Merged

IBX-6200: Changed the was custom styles list is diplayed #109

merged 1 commit into from
Aug 1, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Jul 18, 2023

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-6200
Bug/Improvement yes
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Jul 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Aug 1, 2023
micszo
micszo approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of custom styles is displayed vertically now.

Works fine on Chrome, Firefox and Safari.

QA Approved on Ibexa Experience 4.5.2-dev.

@micszo micszo removed their assignment Aug 1, 2023
@alongosz alongosz added the Bug Something isn't working label Aug 1, 2023
@alongosz alongosz merged commit 507315c into 4.5 Aug 1, 2023
22 checks passed
@alongosz alongosz deleted the horizontal-custom-styles branch August 1, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@alongosz alongosz

@dew326 dew326

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dew326 @GrabowskiM @micszo @lucasOsti @Gengar-i @alongosz