Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8006: Fixed matrix field resolving based on content's origin #43

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Mar 22, 2024

JIRA: https://issues.ibexa.co/browse/IBX-8006

Fixes regression introduced by https://github.com/ibexa/product-catalog/pull/1144.

It orbits around resolving content based on CT containing matrix fieldtype. Registering two resolvers with MatrixFieldValue alias resulted in overriding the first loaded one (Ibexa\FieldTypeMatrix\GraphQL\FieldValueResolver) with the second (Ibexa\ProductCatalog\GraphQL\Resolver\MatrixFieldType\FieldValueResolver) which in turn blowed up when content based on CT with matrix was created.

The idea is to loosen up the type coming to the original resolver and introduce strategies allowing us to properly fetch content both from Ibexa\GraphQL\Value\Item and Ibexa\Contracts\ProductCatalog\Values\ContentAwareProductInterface (tackled within the companion PR https://github.com/ibexa/product-catalog/pull/1154).

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Mar 22, 2024
@konradoboza konradoboza self-assigned this Mar 22, 2024
@konradoboza konradoboza requested a review from a team March 22, 2024 07:22
@webhdx webhdx requested a review from a team March 22, 2024 07:35
@mikadamczyk mikadamczyk requested a review from a team March 22, 2024 08:02
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved oon Ibexa DXP 4.5 commerce.

@konradoboza konradoboza merged commit bddfbfe into 4.5 Mar 28, 2024
13 checks passed
@konradoboza konradoboza deleted the ibx-8006-added-strategy-for-content-resolving branch March 28, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants