Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing service definition #31

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Added missing service definition #31

merged 1 commit into from
Aug 23, 2023

Conversation

mikadamczyk
Copy link
Contributor

No description provided.

@mikadamczyk mikadamczyk added the Bug Something isn't working label Aug 23, 2023
@mikadamczyk mikadamczyk self-assigned this Aug 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikadamczyk mikadamczyk requested review from tischsoic and a team August 23, 2023 11:33
@mikadamczyk mikadamczyk marked this pull request as ready for review August 23, 2023 11:33
Steveb-p
Steveb-p reviewed Aug 23, 2023
View reviewed changes
tests/lib/_fixtures/config/services.yaml
autowire: true
public: true

Ibexa\Core\Repository\EventSubscriber\NameSchemaSubscriber: ~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why isn't this service part of the Core service configuration?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is LegacySetupFactory, my point is moot 😅

@mikadamczyk mikadamczyk merged commit ff9b5f0 into main Aug 23, 2023
14 checks passed
@mikadamczyk mikadamczyk deleted the fix-integration-setup branch August 23, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikadamczyk @Steveb-p @konradoboza @Nattfarinn @ciastektk