Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ibexa\Core\FieldType\User\Type::FIELD_TYPE_IDENTIFIER const #309

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Added Ibexa\Core\FieldType\User\Type::FIELD_TYPE_IDENTIFIER const #309

merged 1 commit into from
Dec 13, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Dec 13, 2023 •
edited
Loading

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v4.6
BC breaks no

See ibexa/admin-ui#1020 (comment)

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@adamwojs adamwojs mentioned this pull request Dec 13, 2023
Merged
2 tasks
@adamwojs adamwojs requested a review from a team December 13, 2023 09:16
@alongosz alongosz requested a review from a team December 13, 2023 13:13
@konradoboza konradoboza requested a review from a team December 13, 2023 13:18
@adamwojs
Copy link
Member Author

CI fixed in #310

@alongosz
Copy link
Member

CI fixed in #310

@adamwojs #310 merged to main. Thanks :)

@adamwojs
Copy link
Member Author

Thanks, PR has been rebased.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs merged commit 3827b5c into main Dec 13, 2023
21 checks passed
@adamwojs adamwojs deleted the ibx_6645 branch December 13, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @alongosz @konradoboza @kisztof @mikadamczyk