Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Container configuration for project types #183

Draft
wants to merge 5 commits into
base: 4.5
Choose a base branch
from

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Dec 21, 2022

Question Answer
JIRA issue n/a
Type improvement
Target Ibexa version v4.3+
BC breaks no

This PR moves parts of IbexaExtension configuration related to project configuration (generic and Platform.Sh) to separate strategies, to remove clutter from IbexaExtension class.

TOOD

  • more refactoring to reduce cognitive complexity
  • tests

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (targeting temporarily against Refactored Container configuration for project types #183)
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@adamwojs
Copy link
Member

@alongosz Is this contribution is still relevant ?

@alongosz
Copy link
Member Author

@alongosz Is this contribution is still relevant ?

Yes.

Base automatically changed from ibx-3740-fix-dfs-config to 4.5 March 27, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants