-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2961: Implemented ConfigurationDumper for Ibexa Encore files #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
alongosz
force-pushed
the
ibx-2961-dump-ibexa-encore-config
branch
from
June 14, 2022 09:57
695f24f
to
9443086
Compare
This was referenced Jun 14, 2022
adamwojs
reviewed
Jun 20, 2022
adamwojs
approved these changes
Jun 20, 2022
mikadamczyk
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could introduce variable/property for $this->projectDir . self::FOO_BAR_BUNDLE_DIR
e.g $this->fooBarBundlePath
Fixed via c7d892c |
damianz5
approved these changes
Jun 20, 2022
katarzynazawada
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.1
+Based on fb9c26f.
This PR provides the new
ConfigurationDumper
class to be used by 1st party Ibexa packages to provide Ibexa Encore extension points, like the one in ibexa/fieldtype-richtext#46.The differences with fb9c26f are that the code was encapsulated into a class, so 1st party usage is as simple as possible. Moreover it's project-first, following philosophy of Symfony which got rid of
AppBundle
and extracted Resources to top-level project directories. It's possible to place required file either in top levelencore/
directory or bundle-levelResources/encore
directory.Why in ibexa/core?
We need to provide an extension point in ibexa/fieldtype-richtext which has no knowledge of AdminUI. At the same time the mechanism used there will be common for the future extension points, so ibexa/core ATM makes the most sense (as core was meant to be a merge of former ezplatform-core and ezplatform-kernel).
Checklist:
$ composer fix-cs
).