Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2961: Implemented ConfigurationDumper for Ibexa Encore files #120

Merged
merged 6 commits into from
Jun 22, 2022

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jun 13, 2022

Question Answer
JIRA issue IBX-2961
Required by
Type feature
Target Ibexa version v4.1+
BC breaks no

Based on fb9c26f.

This PR provides the new ConfigurationDumper class to be used by 1st party Ibexa packages to provide Ibexa Encore extension points, like the one in ibexa/fieldtype-richtext#46.

The differences with fb9c26f are that the code was encapsulated into a class, so 1st party usage is as simple as possible. Moreover it's project-first, following philosophy of Symfony which got rid of AppBundle and extracted Resources to top-level project directories. It's possible to place required file either in top level encore/ directory or bundle-level Resources/encore directory.

Why in ibexa/core?

We need to provide an extension point in ibexa/fieldtype-richtext which has no knowledge of AdminUI. At the same time the mechanism used there will be common for the future extension points, so ibexa/core ATM makes the most sense (as core was meant to be a merge of former ezplatform-core and ezplatform-kernel).

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review.

@alongosz alongosz requested review from adamwojs and a team June 20, 2022 11:32
@alongosz
Copy link
Member Author

alongosz commented Jun 20, 2022

@adamwojs fixed all remarks via fe690df... and via f1ca6ee (my bad).

Copy link
Contributor

@mikadamczyk mikadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could introduce variable/property for $this->projectDir . self::FOO_BAR_BUNDLE_DIR e.g $this->fooBarBundlePath

@alongosz
Copy link
Member Author

you could introduce variable/property for $this->projectDir . self::FOO_BAR_BUNDLE_DIR e.g $this->fooBarBundlePath

Fixed via c7d892c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Feature New feature request QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants