-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2823: Added loadRelation method #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
force-pushed
the
ibx-2823-added-load-relation-method
branch
from
May 27, 2022 08:52
c087bcd
to
0fb0392
Compare
konradoboza
reviewed
May 27, 2022
Co-authored-by: Konrad Oboza <[email protected]>
Co-authored-by: Konrad Oboza <[email protected]>
Merged
2 tasks
konradoboza
approved these changes
May 30, 2022
mikadamczyk
reviewed
Jun 1, 2022
ViniTou
reviewed
Jun 1, 2022
Steveb-p
reviewed
Jun 1, 2022
src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
tests/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabaseTest.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Jun 1, 2022
tests/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabaseTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Paweł Niedzielski <[email protected]>
Co-authored-by: Paweł Niedzielski <[email protected]>
Co-authored-by: Paweł Niedzielski <[email protected]>
…est.php Co-authored-by: Paweł Niedzielski <[email protected]>
Co-authored-by: Andrew Longosz <[email protected]>
Co-authored-by: Andrew Longosz <[email protected]>
…est.php Co-authored-by: Andrew Longosz <[email protected]>
Co-authored-by: Andrew Longosz <[email protected]>
Steveb-p
reviewed
Jun 3, 2022
src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
Jun 3, 2022
src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Longosz <[email protected]>
Co-authored-by: Andrew Longosz <[email protected]>
Steveb-p
approved these changes
Jun 3, 2022
tomaszszopinski
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 4.1 commerce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.1
List of changes:
Ibexa\Contracts\Core\Persistence\Content\Handler::removeRelation
- added optional third argument$destinationContentId
which will be used to invalidate cache tagloadRelation
toIbexa\Contracts\Core\Persistence\Content\Handler
to load relation by idloadRelation
toIbexa\Core\Persistence\Legacy\Content\Gateway
to get relation data from databaseIbexa\Core\Persistence\Cache\ContentHandler::countReverseRelations
for better performancecontent_reverse_relations_count
-crrc
andrelation
-re
$destinationContentId
whereremoveRelation
method is calledChecklist:
$ composer fix-cs
).@ibexa/engineering
).