-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7935: Allowed null value for struct in user Types #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
force-pushed
the
ibx-7935-nullable-user-struct
branch
from
June 25, 2024 12:37
61a6ff2
to
103b2c0
Compare
konradoboza
approved these changes
Jul 1, 2024
webhdx
approved these changes
Jul 1, 2024
@ViniTou is it ready for QA? |
Steveb-p
requested changes
Jul 9, 2024
ViniTou
force-pushed
the
ibx-7935-nullable-user-struct
branch
from
July 10, 2024 07:04
9fc84c5
to
5ebb8a8
Compare
Quality Gate passedIssues Measures |
Steveb-p
approved these changes
Jul 10, 2024
This was referenced Jul 23, 2024
QA Approved on Ibexa DXP Experience and Commerce 4.6-dev. |
juskora
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
https://github.com/ibexa/corporate-account/pull/248 (but this should be tested alone, as it should fix CI in corporate-account)
Description:
As in baseContent, null, due to BC breaks should be also allowed for user related Types.
For QA:
Scenario from IBX-7935 should be retested.
Documentation: