IBX-3872: Fix dropdown popover inside modal #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Sep 23, 2022
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-3872 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | no |
| License | GPL-2.0 |
tischsoic
commented
Sep 23, 2022
| @@ -444,7 +444,7 @@ | |||
| return; | |||
| } | |||
|
|
|||
| const modal = this.container.closest('.modal'); | |||
| const modalDialog = this.container.closest('.modal-dialog'); | |||
There was a problem hiding this comment.
Clicking inside .modal, but outside .modal-dialog is treated by Bootstrap as clicking outside modal, which may close it in some cases. Thus we render the dropdown popover inside .modal-dialog.
lucasOsti
approved these changes
Sep 23, 2022
GrabowskiM
approved these changes
Sep 23, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
micszo
approved these changes
Sep 26, 2022
|
Merged-up:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.