Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3872: Fix dropdown popover inside modal #580

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

tischsoic
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-3872
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

@@ -444,7 +444,7 @@
return;
}

const modal = this.container.closest('.modal');
const modalDialog = this.container.closest('.modal-dialog');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking inside .modal, but outside .modal-dialog is treated by Bootstrap as clicking outside modal, which may close it in some cases. Thus we render the dropdown popover inside .modal-dialog.

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.2.2-dev.

@micszo micszo removed their assignment Sep 26, 2022
@dew326 dew326 merged commit 98cf53b into 4.2 Sep 26, 2022
@dew326 dew326 deleted the IBX-3872-modal-closes-after-dropdown-click branch September 26, 2022 10:25
@tischsoic
Copy link
Contributor Author

Merged-up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants