IBX-3523: Introduced tabs to left sidebar in Content Edit interface #526
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| system: | ||
| admin_group: | ||
| admin_ui_forms: | ||
| content_edit: | ||
| form_templates: | ||
| - { template: '@ibexadesign/content/form_fields.html.twig', priority: 0 } | ||
|
|
||
| field_templates: | ||
| - { template: '@ibexadesign/ui/field_type/preview/content_fields.html.twig', priority: 20 } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| (function (global, doc, ibexa) { | ||
| const navigationMenu = doc.querySelector('.ibexa-navigation-menu'); | ||
|
|
||
| if (!navigationMenu) { | ||
| return; | ||
| } | ||
|
|
||
| const SECTION_ADJUST_MARGIN_TOP = 20; | ||
| const formContainerNode = doc.querySelector('.ibexa-edit-content'); | ||
| const getSecondarySectionActiveItems = () => { | ||
| const secondarySectionItems = formContainerNode.querySelectorAll( | ||
| '.ibexa-edit-content__primary-section--active .ibexa-edit-content__secondary-section', | ||
| ); | ||
|
|
||
| return [...secondarySectionItems]; | ||
| }; | ||
| let currentlyVisibleSections = getSecondarySectionActiveItems(); | ||
| const fitSecondarySections = () => { | ||
| const primarySection = doc.querySelector('.ibexa-edit-content__primary-section--active'); | ||
| const contentColumn = doc.querySelector('.ibexa-main-container__content-column'); | ||
| const firstSection = primarySection.firstElementChild; | ||
| const lastSection = primarySection.lastElementChild; | ||
| const contentContainer = contentColumn.querySelector('.ibexa-edit-content__container'); | ||
|
|
||
| contentContainer.style.paddingBottom = '0px'; | ||
|
There was a problem hiding this comment. Do we have to set it even for a case in which we are setting it below again? There was a problem hiding this comment. It's kinda of a reset, notice that we set this style after two |
||
|
|
||
| if (!firstSection.isSameNode(lastSection) && lastSection.offsetHeight) { | ||
| const headerContainer = doc.querySelector('.ibexa-edit-header__container'); | ||
| const heightFromLastSection = contentContainer.offsetHeight - lastSection.offsetTop; | ||
| const contentColumnBodyHeight = contentColumn.offsetHeight - headerContainer.offsetHeight; | ||
| const heightDiff = contentColumnBodyHeight - heightFromLastSection; | ||
|
|
||
| if (heightDiff > 0) { | ||
| contentContainer.style.paddingBottom = `${heightDiff}px`; | ||
| } | ||
| } | ||
| }; | ||
| const navigateTo = (targetId) => { | ||
| const secondarySectionNode = formContainerNode.querySelector(`.ibexa-edit-content__secondary-section[data-id="${targetId}"]`); | ||
|
|
||
| formContainerNode.scrollTo({ | ||
| top: secondarySectionNode.offsetTop, | ||
| behavior: 'smooth', | ||
| }); | ||
| }; | ||
| const setActiveSecondaryMenu = (node) => { | ||
| const secondaryMenuItems = doc.querySelectorAll( | ||
| '.ibexa-navigation-menu__secondary--active .ibexa-navigation-menu__secondary-item-btn', | ||
| ); | ||
|
|
||
| secondaryMenuItems.forEach((item) => { | ||
| item.classList.toggle('ibexa-navigation-menu__secondary-item-btn--active', item.isSameNode(node)); | ||
| }); | ||
| }; | ||
| const showPrimarySection = (id) => { | ||
| const primarySectionItems = formContainerNode.querySelectorAll('.ibexa-edit-content__primary-section'); | ||
|
|
||
| primarySectionItems.forEach((item) => { | ||
| item.classList.toggle('ibexa-edit-content__primary-section--active', item.dataset.id === id); | ||
| }); | ||
|
|
||
| currentlyVisibleSections = getSecondarySectionActiveItems(); | ||
|
|
||
| fitSecondarySections(); | ||
| }; | ||
| const showSecondaryMenu = (node) => { | ||
|
There was a problem hiding this comment. It would be nice to have such a function also for the primary menu. |
||
| const items = doc.querySelectorAll('.ibexa-navigation-menu__secondary'); | ||
|
|
||
| items.forEach((item) => item.classList.toggle('ibexa-navigation-menu__secondary--active', item.isSameNode(node))); | ||
| }; | ||
| const onSelectPrimaryMenuList = (event) => { | ||
| const { targetId } = event.currentTarget.dataset; | ||
| const secondaryMenuNode = doc.querySelector(`.ibexa-navigation-menu__secondary[data-id="${targetId}"]`); | ||
| const primaryMenuItems = doc.querySelectorAll('.ibexa-navigation-menu__primary--list .ibexa-navigation-menu__primary-item'); | ||
|
|
||
| primaryMenuItems.forEach((item) => { | ||
| item.classList.toggle('ibexa-navigation-menu__primary-item--active', item.isSameNode(event.currentTarget)); | ||
| }); | ||
| showPrimarySection(targetId); | ||
|
|
||
| if (secondaryMenuNode) { | ||
| showSecondaryMenu(secondaryMenuNode); | ||
| } | ||
| }; | ||
| const onSelectPrimaryMenuDropdown = (event) => { | ||
| const targetId = event.currentTarget.value; | ||
| const secondaryMenuNode = doc.querySelector(`.ibexa-navigation-menu__secondary[data-id="${targetId}"]`); | ||
|
|
||
| showPrimarySection(targetId); | ||
|
|
||
| if (secondaryMenuNode) { | ||
| showSecondaryMenu(secondaryMenuNode); | ||
| } | ||
| }; | ||
| const onSelectSecondaryMenu = (event) => { | ||
| const { targetId } = event.currentTarget.dataset; | ||
|
|
||
| navigateTo(targetId); | ||
| }; | ||
| const attachPrimaryMenuListEvents = () => { | ||
| const items = doc.querySelectorAll('.ibexa-navigation-menu__primary--list .ibexa-navigation-menu__primary-item'); | ||
|
|
||
| items.forEach((item) => item.addEventListener('click', onSelectPrimaryMenuList, false)); | ||
| }; | ||
| const attachPrimaryMenuDropdownEvents = () => { | ||
| const sourceSelect = doc.querySelector('.ibexa-navigation-menu__primary--dropdown .ibexa-dropdown__source .ibexa-input'); | ||
|
|
||
| if (!sourceSelect) { | ||
| return; | ||
| } | ||
|
|
||
| sourceSelect.addEventListener('change', onSelectPrimaryMenuDropdown, false); | ||
| }; | ||
| const attachSecondaryMenuEvents = () => { | ||
| const items = doc.querySelectorAll('.ibexa-navigation-menu .ibexa-navigation-menu__secondary-item-btn'); | ||
|
|
||
| items.forEach((item) => item.addEventListener('click', onSelectSecondaryMenu, false)); | ||
| }; | ||
| const attachScrollContainerEvents = () => { | ||
| const allSections = [...formContainerNode.querySelectorAll('.ibexa-edit-content__secondary-section')]; | ||
| const headerContainer = doc.querySelector('.ibexa-edit-header__container'); | ||
| let previousFirstVisibleSection = null; | ||
|
|
||
| if (formContainerNode && allSections.length) { | ||
| formContainerNode.addEventListener('scroll', () => { | ||
| let firstVisibleSection = currentlyVisibleSections.find((section) => { | ||
| const { top, height } = section.getBoundingClientRect(); | ||
|
|
||
| return top + height >= headerContainer.offsetHeight + SECTION_ADJUST_MARGIN_TOP; | ||
| }); | ||
|
|
||
| if (!firstVisibleSection) { | ||
| firstVisibleSection = currentlyVisibleSections.at(-1); | ||
| } | ||
|
|
||
| if (previousFirstVisibleSection === firstVisibleSection) { | ||
| return; | ||
| } | ||
|
|
||
| previousFirstVisibleSection = firstVisibleSection; | ||
|
|
||
| const targetId = firstVisibleSection.dataset.id; | ||
|
|
||
| const secondaryMenuNode = doc.querySelector( | ||
| `.ibexa-navigation-menu__secondary--active .ibexa-navigation-menu__secondary-item-btn[data-target-id="${targetId}"]`, | ||
| ); | ||
|
|
||
| setActiveSecondaryMenu(secondaryMenuNode); | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
| attachPrimaryMenuListEvents(); | ||
| attachPrimaryMenuDropdownEvents(); | ||
| attachSecondaryMenuEvents(); | ||
| attachScrollContainerEvents(); | ||
| fitSecondarySections(); | ||
| ibexa.helpers.tooltips.parse(navigationMenu); | ||
| })(window, window.document, window.ibexa); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,12 @@ | |
| max-width: calculateRem(1600px); | ||
| } | ||
| } | ||
|
|
||
| &__primary-section { | ||
| display: none; | ||
|
|
||
| &--active { | ||
| display: block; | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes you are using
formContainerNodeand sometimes not, is there any reason behind it?