Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2918: Improvement collapse panel #429

Merged
merged 2 commits into from
May 23, 2022
Merged

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented May 18, 2022

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-2918
Bug fix? no
New feature? no
BC breaks? no
Tests pass? no
Doc needed? no
License GPL-2.0

Change togglers in view tab from arrows to button with arrow and a label

Screenshot 2022-05-18 at 13 36 20

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti force-pushed the IBX-2918-Improvement-collapse-panel branch from 472690b to bef8111 Compare May 18, 2022 11:33
@lucasOsti lucasOsti changed the base branch from main to 4.1 May 18, 2022 11:52
&:hover {
color: $ibexa-color-primary;
text-decoration: none;

&::after {
border-top: calculateRem(5px) solid $ibexa-color-primary;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-top: calculateRem(5px) solid $ibexa-color-primary;
border-top-color: $ibexa-color-primary;

}
}

&:after {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&:after {
&::after {

@dew326 dew326 merged commit 0dcd628 into 4.1 May 23, 2022
@dew326 dew326 deleted the IBX-2918-Improvement-collapse-panel branch May 23, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants