Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2796: reference correct property #405

Merged
merged 1 commit into from
Apr 27, 2022
Merged

IBX-2796: reference correct property #405

merged 1 commit into from
Apr 27, 2022

Conversation

pspanja
Copy link
Contributor

@pspanja pspanja commented Apr 26, 2022 •
edited
Loading

Question Answer
Tickets IBX-2796
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326 dew326 changed the base branch from main to 4.1 April 26, 2022 11:13
@dew326 dew326 changed the base branch from 4.1 to main April 26, 2022 11:13
@dew326
Copy link
Contributor

dew326 commented Apr 26, 2022

Hi @pspanja, thanks for PR.
As this is a bug in 4.1.1 it should go to the 4.1 branch. Please rebase your branch and change the target branch for this PR.

@pspanja pspanja changed the base branch from main to 4.1 April 26, 2022 12:57
@pspanja
Copy link
Contributor Author

pspanja commented Apr 26, 2022

@dew326 done.

@dew326 dew326 added Bug Something isn't working Ready for review labels Apr 26, 2022
@micszo micszo self-assigned this Apr 26, 2022
@barw4 barw4 mentioned this pull request Apr 27, 2022
Closed
2 tasks
micszo
micszo approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested successfully on Ibexa DXP 4.1.1 editions with diff.

Discovered issues linked to JIRA ticket.

@micszo micszo removed their assignment Apr 27, 2022
@dew326 dew326 merged commit 725066b into ibexa:4.1 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pspanja @dew326 @GrabowskiM @tischsoic @micszo @mikadamczyk @Nattfarinn