IBX-2627: dropdown small styling issues #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Mar 30, 2022
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-2627 |
| Bug fix? | yes/no |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | no |
| License | GPL-2.0 |
lucasOsti
approved these changes
Mar 30, 2022
dew326
approved these changes
Mar 30, 2022
GrabowskiM
reviewed
Apr 4, 2022
| @@ -283,6 +285,21 @@ | |||
| return this.itemsContainer; | |||
| } | |||
|
|
|||
| toggleSourceFocus(isFocused) { | |||
| const isDisabled = this.container.classList.contains('ibexa-dropdown--disabled'); | |||
| const shouldFocus = isFocused && !isDisabled; | |||
There was a problem hiding this comment.
As I understand, source input is still focusable, so there's possibility that user will focus on it, but as dropdown is disabled, it won't be visible as focused.
Probably source input should be disabled as well, when dropdown is disabled?
GrabowskiM
approved these changes
Apr 7, 2022
bogusez
approved these changes
Apr 13, 2022
|
@tischsoic please merge up to 4.1 and main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.