Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2627: dropdown small styling issues #382

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

tischsoic
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-2627
Bug fix? yes/no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

@@ -283,6 +285,21 @@
return this.itemsContainer;
}

toggleSourceFocus(isFocused) {
const isDisabled = this.container.classList.contains('ibexa-dropdown--disabled');
const shouldFocus = isFocused && !isDisabled;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, source input is still focusable, so there's possibility that user will focus on it, but as dropdown is disabled, it won't be visible as focused.

Probably source input should be disabled as well, when dropdown is disabled?

@bogusez bogusez self-assigned this Apr 12, 2022
@dew326 dew326 merged commit 7079ace into 4.0 Apr 25, 2022
@dew326 dew326 deleted the IBX-2627-dropdown-small-styling-bugs branch April 25, 2022 10:56
@dew326
Copy link
Contributor

dew326 commented Apr 25, 2022

@tischsoic please merge up to 4.1 and main.

@tischsoic
Copy link
Contributor Author

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants