IBX-2177: Page builder - Error state on icon #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
approved these changes
Mar 1, 2022
tischsoic
reviewed
Mar 2, 2022
| @@ -182,6 +189,7 @@ | |||
| return; | |||
| } | |||
|
|
|||
| this.isError = validationResult.isError; | |||
There was a problem hiding this comment.
I'm not sure whether isError is the best name. Maybe hasError? WDYT? 🤔
dew326
approved these changes
Mar 3, 2022
GrabowskiM
approved these changes
Mar 3, 2022
tischsoic
approved these changes
Mar 4, 2022
lucasOsti
force-pushed
the
IBX-2177-error-state
branch
from
018f6eb
to
15061a1
Compare
bogusez
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)