-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2399: Introduce reusable twig modal component #335
Conversation
@@ -296,7 +296,7 @@ $modal-header-border-color: $ibexa-color-light-500; | |||
$modal-title-font-size: 28px; | |||
$modal-content-border-width: 0; | |||
$modal-content-border-radius: $ibexa-border-radius; | |||
$modal-inner-padding: 24px 0; | |||
$modal-inner-padding: calculateRem(24px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be single value in rem
because it is used in such expression in bootstrap scss internals:
padding: $modal-inner-padding - $modal-footer-margin-between * .5;
ref. https://github.com/ibexa/admin-ui-assets/blob/792cd47c43ab5cc05609e6a45242ef87934d5afb/src/bundle/Resources/public/vendors/bootstrap/scss/_modal.scss#L131
otherwise it produces:
@@ -3,5 +3,5 @@ | |||
@function calculateRem($size) { | |||
$remSize: div($size, $base-font-size); | |||
|
|||
@return #{$remSize}rem; | |||
@return $remSize + 0rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version was actually not converting values to rem
measurement in SCSS. Change required for $modal-inner-padding
;
80b8b9f
to
fde381a
Compare
|
||
{% set no_header = no_header|default(false) %} | ||
|
||
{% set size = size|default(false) %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed in private, no mixed type.
fde381a
to
0855b1e
Compare
ef2d1fd
to
a457541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Approved on Ibexa Commerce 4.0.3-dev with 11 branches.
Related PRs: