Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1496: When configuring a Content Type - the Category dropdown should removed #329

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

lucasOsti
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1496
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? no
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti changed the title IBX-1496: Creating a new language - the language code changed from a dropdown to input field in the new design IBX-1496: When configuring a Content Type - the Category dropdown should removed Feb 16, 2022
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also code style needs to be fixed

'label' => /** @Desc("Category") */ 'field_definition.field_group',
'disabled' => $isTranslation,
]
HiddenType::class,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused $fieldsGroups variable (lines 78-78) should be removed as well.

@adamwojs adamwojs requested review from Nattfarinn, mikadamczyk and a team February 21, 2022 08:37
@lucasOsti lucasOsti added Bug Something isn't working Ready for QA labels Feb 22, 2022
@tomaszszopinski tomaszszopinski self-assigned this Feb 24, 2022
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 4.0.x-dev

@dew326 dew326 merged commit 9165810 into ibexa:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants