-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8525: Added language code validation #1356
Conversation
8473d63
to
0a58d27
Compare
0c36325
to
a661831
Compare
a661831
to
cea2375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll extract PHP 8.3-only errors later to not duplicate them between baselines, as I expect some of them to be shared between 8.0 and 8.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text message should be shortened according to our style guide:
The Language code {{ value }} contains illegal characters. Language code should start with a letter, digit or underscore and only contain letters, digits, underscores, hyphens and colons.
The icon aligned to the top, and the notification in the lower right corner in the red color.
Probably frontend work required.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notification should look as in the Design System
https://www.figma.com/design/4sbNQyNLhFFwxWDH89Rf9X/%F0%9F%9F%A2-%5BIbexa%5D-Design-System?node-id=1635-71820&t=fJQaf2Z1Co2Lbxk8-4
red color with the exclamation mark icon.
@juskora This change affects global scope and I would really prefer to proceed it as separate issue. Could you please create JIRA issue with bug report and identify other places where given bug occurs? |
@adamwojs Sure, I'll do that, thanks. |
QA Approved on Ibexa DXP Commerce 4.6-dev. |
Thank you @juskora! |
Description:
Added language code validation
Documentation:
Mention language code format