Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8525: Added language code validation #1356

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

tbialcz
Copy link
Contributor

@tbialcz tbialcz commented Oct 3, 2024

🎫 Issue IBX-8525

Description:

Added language code validation

Documentation:

Mention language code format

@tbialcz tbialcz changed the title IBX-8525-language-codelanguage-validation IBX-8525: Added language code validation Oct 3, 2024
@adamwojs adamwojs force-pushed the IBX-8525-language-codelanguage-validation branch from 8473d63 to 0a58d27 Compare October 3, 2024 11:32
@tbialcz tbialcz requested review from adamwojs, Steveb-p and a team October 3, 2024 11:35
@tbialcz tbialcz force-pushed the IBX-8525-language-codelanguage-validation branch 2 times, most recently from 0c36325 to a661831 Compare October 3, 2024 11:51
@tbialcz tbialcz force-pushed the IBX-8525-language-codelanguage-validation branch from a661831 to cea2375 Compare October 3, 2024 12:01
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll extract PHP 8.3-only errors later to not duplicate them between baselines, as I expect some of them to be shared between 8.0 and 8.3.

@konradoboza konradoboza requested a review from a team October 3, 2024 12:29
Copy link
Contributor

@juskora juskora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text message should be shortened according to our style guide:
The Language code {{ value }} contains illegal characters. Language code should start with a letter, digit or underscore and only contain letters, digits, underscores, hyphens and colons.
The icon aligned to the top, and the notification in the lower right corner in the red color.
image

Probably frontend work required.

@tbialcz tbialcz requested review from a team and juskora October 7, 2024 13:10
Copy link

sonarcloud bot commented Oct 7, 2024

Copy link
Contributor

@juskora juskora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notification should look as in the Design System
https://www.figma.com/design/4sbNQyNLhFFwxWDH89Rf9X/%F0%9F%9F%A2-%5BIbexa%5D-Design-System?node-id=1635-71820&t=fJQaf2Z1Co2Lbxk8-4
red color with the exclamation mark icon.
image

@adamwojs
Copy link
Member

adamwojs commented Oct 9, 2024

The notification should look as in the Design System
https://www.figma.com/design/4sbNQyNLhFFwxWDH89Rf9X/%F0%9F%9F%A2-%5BIbexa%5D-Design-System?node-id=1635-71820&t=fJQaf2Z1Co2Lbxk8-4
red color with the exclamation mark icon.

@juskora This change affects global scope and I would really prefer to proceed it as separate issue. Could you please create JIRA issue with bug report and identify other places where given bug occurs?

@juskora
Copy link
Contributor

juskora commented Oct 10, 2024

@adamwojs Sure, I'll do that, thanks.

@juskora
Copy link
Contributor

juskora commented Oct 10, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@adamwojs
Copy link
Member

Thank you @juskora!

@tbialcz tbialcz merged commit c80979b into 4.6 Oct 10, 2024
28 checks passed
@tbialcz tbialcz deleted the IBX-8525-language-codelanguage-validation branch October 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.