IBX-8593: Remove depracation warnings from scss build after upgrading sass package #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dew326
approved these changes
Jul 19, 2024
adamwojs
approved these changes
Jul 22, 2024
lucasOsti
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
I also removed two unused files (user menu was redesigned and got new classes at some point)
For QA:
Probably no tests at all, or run
yarn encore devand watch console if there are any warnings from other files than ones inpublic/bundles/ibexaadminuiassetsAlso, needs to run
composer run post-update-cmdas some files uses built version from public directoryDocumentation: