Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7044: Redirect after settings update #1173

Open
wants to merge 10 commits into
base: 4.6
Choose a base branch
from
Open

IBX-7044: Redirect after settings update #1173

wants to merge 10 commits into from

Conversation

Gengar-i
Copy link
Contributor

Question Answer
JIRA issue IBX-7044
Type bug
Target version v4.6
BC breaks no
Doc needed no

Redirect to page/dashboard builder after going into settings from welcome builder modal.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Gengar-i Gengar-i requested a review from dew326 February 20, 2024 11:05
@Gengar-i Gengar-i force-pushed the ibx-7044-redirect-after-settings-update branch from cdc5ddf to b11457d Compare March 13, 2024 11:13
@Gengar-i Gengar-i changed the base branch from main to 4.6 March 15, 2024 09:04
@Gengar-i Gengar-i force-pushed the ibx-7044-redirect-after-settings-update branch from e1ecc47 to b11457d Compare March 18, 2024 09:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk
Copy link
Contributor

@Steveb-p Will you continue this?

mikadamczyk
mikadamczyk approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@mikadamczyk mikadamczyk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Steveb-p Besides your remarks LGTM ;)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p left review comments

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Gengar-i @mikadamczyk @Steveb-p @GrabowskiM @dew326 @lucasOsti @Nattfarinn @ciastektk @ViniTou