Fixed issue with pynbody SimArrays #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version returned an error where calling f1['rho'] did not work since 'f1' still contained an index for the star particles.
Since all we care about are the gas particles, and the star particles are at the end of the iorder (as per convention), we can set the 'iorder' and 'particle_nums' arrays to be the size of 'f.g' instead of 'f'. Then, since 'clump_nums' will be the size of 'f', we can slice the star particles at the end of the array out and mask 'f.g', 'iorder', and 'particle_nums' where 'clump_nums' > 0. This ensures that 'f1' contains only gas particles, and that all the arrays are the same size.