You can now specify what URLs you want to download in a file #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the test failed: |
iawia002
reviewed
Oct 25, 2019
utils/utils.go
Outdated
| @@ -154,9 +154,6 @@ func ParseInputFile(r io.Reader) []string { | |||
| for scanner.Scan() { | |||
| totalLines++ | |||
| universalURL := strings.TrimSpace(scanner.Text()) | |||
| if universalURL == "" { | |||
There was a problem hiding this comment.
if you remove this, there might be empty strings in temp
There was a problem hiding this comment.
yes, I know. But now that you can choose what urls you want, so this shouldn't be a problem. Also if I think about a file filled with url there shouldn't be any empty lines anyway?
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 69.95% 73.47% +3.52%
==========================================
Files 4 4
Lines 203 230 +27
==========================================
+ Hits 142 169 +27
Misses 59 59
Partials 2 2
Continue to review full report at Codecov.
|
iawia002
approved these changes
Oct 28, 2019
Stegosawr
changed the title
|
I am so sorry... fixed it now. Thanks for pointing it out and all the feedback you gave me :> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #529
Merged all commits into one
@iawia002