Make TwoPane layout adaptive to screen orientation #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwz
changed the title
|
Hi @ianyh, any chance you could take a look at this PR? |
|
Yeah, you need to pull in upstream. It has a fix for the tests compilation issue. |
ok - done 👍🏻 |
|
hey @ianyh, any chance this can be merged if you're happy with the changes? |
Merged
ianyh
added a commit
to reyk/Amethyst
that referenced
this pull request
May 7, 2022
* development: Throw window to any space across multiple screens. (ianyh#1209) Make TwoPane layout adaptive to screen orientation (ianyh#1182) Minor fix (line 69) (ianyh#1230) Bump cocoapods-downloader from 1.5.1 to 1.6.3 (ianyh#1226) Fix the layout HUD when multiple screen are arranged vertically (ianyh#1162) (ianyh#1163) Bump version to 0.15.6 (ianyh#1205) Remove errant link (ianyh#1207) Replace gitter with GitHub Discussions (ianyh#1206) Update Window.swift (ianyh#1203) Fix setup.sh so that it correctly checks for rbenv (ianyh#1198) add regex suuport to floating windows title matching (ianyh#1166) Get the build going (ianyh#1185) Fix for move to window to space - ianyh#1174 (ianyh#1184) Update cocoapods in Gemfile (ianyh#1159) Remove travis file (ianyh#1158) Create GitHub Action for running tests (ianyh#1157) Add some common macOS agents to ignored list (ianyh#1156) Bump addressable from 2.7.0 to 2.8.0 (ianyh#1136)
ianyh
added a commit
that referenced
this pull request
May 21, 2022
* development: Fix swapping with two windows visible for two-pane layout (#1241) Add 4Column layout for ultra-wide screens (#1154) Throw window to any space across multiple screens. (#1209) Make TwoPane layout adaptive to screen orientation (#1182) Minor fix (line 69) (#1230) Bump cocoapods-downloader from 1.5.1 to 1.6.3 (#1226) Fix the layout HUD when multiple screen are arranged vertically (#1162) (#1163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been experimenting recently with a vertical monitor setup and I decided to follow up on #1124 and made the Two Pane layout to adapt to horizontal/vertical view depending on the screen orientation (i.e. it does vertical tiling on a vertical monitor).
I've used it a lot over the last couple of days on both a horizontal and a vertical monitor - I have a keyboard shortcut to trigger it and imho It seems to be way more convenient to reuse the existing layout rather than create a separate layout, but please let me know if you'd rather have it as a separate one.
Please see a short demo below:
CleanShot.2022-01-13.at.00.22.41-converted.2.mp4