Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw focused window shortcuts not working after MacOS 12.2 upgrade #1192

Closed
NZLostboy opened this issue Jan 27, 2022 · 23 comments
Closed

Throw focused window shortcuts not working after MacOS 12.2 upgrade #1192

NZLostboy opened this issue Jan 27, 2022 · 23 comments

Comments

@NZLostboy
Copy link

NZLostboy commented Jan 27, 2022

After upgrading to MacOS 12.2, the 'throw focused window to spaces' doesn't seem to be working anymore.
No error shown, but it just doesn't shift the window to the specified space.
The 'Swap focused window' shortcuts seem to be working fine.
I can still manually shift windows between spaces using the Apple default shortcuts (Click title then ctrl #).

Versions:
MacOS 12.2
Amethyst 0.15.5 (92)

Reproduction:
Using the versions above, set your short cuts for 'throw focused window to spaces', restart Amethyst, attempt to throw a window to a new space and observe it doesn't work.

Debug Info
❯ /Applications/Amethyst.app/Contents/MacOS/Amethyst --debug-info
Version: 0.15.5 (92)

OS version: Version 12.2 (Build 21D49)

Screens:
(0.0, 0.0, 2560.0, 1080.0) [(0.0, 0.0, 2560.0, 1080.0)]

Configuration:
window-minimum-width: 0
screen-padding-left: 0
enables-layout-hud: 0
mouse-swaps-windows: 1
mouse-follows-focus: 1
floating: (
)
mod1: (
option,
shift
)
screen-padding-bottom: 0
window-resize-step: 5
mod2: (
option,
shift,
control
)
layouts: (
tall,
wide,
fullscreen,
column
)
debug-layout-info: 0
screen-padding-right: 0
follow-space-thrown-windows: 0
use-canary-build: 1
float-small-windows: 1
window-margin-size: 0
window-minimum-height: 0
new-windows-to-main: 0
screen-padding-top: 0
window-margins: 0
floating-is-blacklist: 1
enables-layout-hud-on-space-change: 0
focus-follows-mouse: 0
restore-layouts-on-launch: 1
mouse-resizes-windows: 1
ignore-menu-bar: 0

*** Additional: ***
I haven't changed my configuration in any way recently, has been working for 6 months until the update.

@ClonedOne
Copy link

Can confirm, same versions of MacOs and Amethyst, the "throw focused window" shortcuts are not working

@antoniopantaleo
Copy link

Take a look here #1184
The problem has been fixed. Just waiting for a new release

@mwz
Copy link
Contributor

mwz commented Feb 3, 2022

Hi @ianyh, any chance we could get a new release published with this fix?

@danielxul
Copy link

danielxul commented Feb 6, 2022

I can confirm this issue.

@simonedamico
Copy link

Please, release 😭

@EttVenter
Copy link

Please! 😅

@danielxul
Copy link

Release it, please.

@legat1
Copy link

legat1 commented Feb 14, 2022

Take a look here #1184 The problem has been fixed. Just waiting for a new release

Just tried this fix building development branch but unfortunately this issue is still here 😭

@rublev
Copy link

rublev commented Feb 15, 2022

Lmao I spent like 3 hours on this before realizing wait... maybe its the OS upgrade. AHhhhh

@sloterplas
Copy link

hi @ianyh, are you actively working on this project?

@ianyh
Copy link
Owner

ianyh commented Feb 15, 2022

Short answer is yes, but my availability is spotty due to other responsibilities.

@dzanotto
Copy link
Contributor

It looks like I've fixed the problem locally by using CGSMoveWindowsToManagedSpace instead of CGSAddWindowsToSpaces + CGSRemoveWindowsFromSpaces.
To do that in a proper way, I think that CGSMoveWindowsToManagedSpace should be added to CGSSpace.h that comes with Silica (but maybe I'm completely wrong...).
Does it make sense @ianyh?

@NZLostboy
Copy link
Author

NZLostboy commented Feb 23, 2022

The development branch build seems to have solved my problem, thanks @dzanotto
For anyone not wanting to build their own, you will have to wait for the next release

  • Edited, turns out it didn't fix it properly, it only worked for a while

@dzanotto
Copy link
Contributor

The development branch build seems to have solved my problem, thanks @dzanotto For anyone not wanting to build their own, you will have to wait for the next release

This puzzles me a bit
I was able to reproduce the problem with the app built from the development branch.
Then I've fixed it by applying the changes mentioned in the previous comment.
So I don't know :(

@mruell
Copy link

mruell commented Feb 23, 2022

@ianyh

is there already a plan for the next release?

Best,
Marvin

@ianyh
Copy link
Owner

ianyh commented Feb 23, 2022

There's a different issue that @dzanotto fixed involving switching spaces that people could be confusing this with.

@dzanotto, I'll give your change with the new API a shot. That's a nice find.

I did upgrade to 12.2 last night to force myself to fix it and get a release out. 😂💀

dzanotto added a commit to dzanotto/CGSInternal that referenced this issue Feb 23, 2022
Added CGSMoveWindowsToManagedSpace
ianyh/Amethyst#1192
dzanotto added a commit to dzanotto/Amethyst that referenced this issue Feb 23, 2022
Moved from CGSAddWindowsToSpaces + CGSRemoveWindowsFromSpaces to CGSMoveWindowsToManagedSpace
ianyh#1192
@dzanotto
Copy link
Contributor

There's a different issue that @dzanotto fixed involving switching spaces that people could be confusing this with.

Yes, you're probably right.

@dzanotto, I'll give your change with the new API a shot. That's a nice find.

I've created a PR for CGSInternal and one for Amethyst. I hope it can help.

I did upgrade to 12.2 last night to force myself to fix it and get a release out. 😂💀

This is a good strategy to fix bugs, painful but good 🤣

@legat1
Copy link

legat1 commented Feb 23, 2022

I tested @dzanotto fix with success, so I can confirm the fix.
Thank you @dzanotto.

@NZLostboy
Copy link
Author

The development branch build seems to have solved my problem, thanks @dzanotto For anyone not wanting to build their own, you will have to wait for the next release

This puzzles me a bit I was able to reproduce the problem with the app built from the development branch. Then I've fixed it by applying the changes mentioned in the previous comment. So I don't know :(

Puzzled me too, I swear it was working for a while after I built it, today its not working again. I edited my comment, you are right its not fixed.

@ianyh ianyh closed this as completed in f682be9 Feb 26, 2022
@andbenn
Copy link

andbenn commented Mar 3, 2022

I recently upgraded to Monterey 12.0.1 and hit this. It seems if I use the keybinding twice to move a window to another space, the second action moves the window. The first key action does something, as I see other windows on the current space adjust - but I haven't had time to figure that out.

@NZLostboy
Copy link
Author

I recently upgraded to Monterey 12.0.1 and hit this. It seems if I use the keybinding twice to move a window to another space, the second action moves the window. The first key action does something, as I see other windows on the current space adjust - but I haven't had time to figure that out.

If you build from the dev branch, this has been fixed :) Otherwise you will have to wait for a new release

@lwouis
Copy link

lwouis commented May 7, 2022

@dzanotto the CGSMoveWindowsToManagedSpace doesn't seem to move fullscreen windows. The CGSAddWindowsToSpaces API did move them.

How did you work around this limitation? It's a blocker for my project (https://github.com/lwouis/alt-tab-macos), and I'm curious how you guys dealt with CGSAddWindowsToSpaces being broken from macOS 12.2 onward.

@dzanotto
Copy link
Contributor

dzanotto commented May 9, 2022

@dzanotto the CGSMoveWindowsToManagedSpace doesn't seem to move fullscreen windows. The CGSAddWindowsToSpaces API did move them.

How did you work around this limitation? It's a blocker for my project (https://github.com/lwouis/alt-tab-macos), and I'm curious how you guys dealt with CGSAddWindowsToSpaces being broken from macOS 12.2 onward.

I confirm it doesn't seem to move fullscreen windows and TBH I don't even know if Amethyst was ever supposed to do so 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests