Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use refs for div component instead findDOMNode #708

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Use refs for div component instead findDOMNode #708

merged 1 commit into from
Apr 3, 2017

Conversation

Rebulus
Copy link
Contributor

@Rebulus Rebulus commented Apr 3, 2017

Hi.

As I know, ReactTestRenderer doesn't work well with findDOMNode and I caught an error with it.
facebook/react#8324
This pull should fix that issue.

@ianstormtaylor ianstormtaylor merged commit 7794ebe into ianstormtaylor:master Apr 3, 2017
@Rebulus Rebulus deleted the exclude-find-dom-node branch April 3, 2017 16:30
yalu pushed a commit to yalu/slate that referenced this pull request Apr 16, 2017
@Rebulus
use refs for div component instead findDOMNode (ianstormtaylor#708)
87c2b06
@tjbenneche tjbenneche mentioned this pull request Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rebulus @ianstormtaylor