Reset state.isDraggingInternally
using global event handlers
#5664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Listen for
dragend
anddrop
events globally to resetstate.isDraggingInternally
. In Firefox, if a drop handler initiates an operation that causes the originally dragged element to unmount, that element will not emit adragend
event.Issue
Fixes: #5663
Example
See issue
Context
We may want to remove the React
onDragEnd
handler, since after this change, all it does is delegate the event if certain conditions are met.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)