Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset state.isDraggingInternally using global event handlers #5664

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

12joan
Copy link
Contributor

@12joan 12joan commented Jun 21, 2024

Description
Listen for dragend and drop events globally to reset state.isDraggingInternally. In Firefox, if a drop handler initiates an operation that causes the originally dragged element to unmount, that element will not emit a dragend event.

Issue
Fixes: #5663

Example
See issue

Context
We may want to remove the React onDragEnd handler, since after this change, all it does is delegate the event if certain conditions are met.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 89b250a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit 0016f98 into ianstormtaylor:main Jun 23, 2024
10 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state.isDraggingInternally is stale after calling Transforms.wrapNodes in a drop handler outside the editor
2 participants