Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Slate breaks on load on Safari < 16.4 #5503

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

janpaepke
Copy link
Contributor

@janpaepke janpaepke commented Aug 29, 2023

Description
This is a very serious issue, as it breaks the app using slate on load, not even when interacting with certain parts of slate.

For details see issue below.

Issue
Fixes: #5502

Example
image

Context
The change makes the check a little bit more verbose but works in exactly the same way: We're testing the user agent for 'Wechat' but exclude 'MacWechat'.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: e93c885

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit e308cd6 into ianstormtaylor:main Aug 29, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.98.2 breaks on recent Safari versions
2 participants