Support serialization / deserialization of annotations #3092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Adding a feature
What's the new behavior?
Annotations can now be serialized and deserialized in the same way marks can.
How does this change work?
For serializing, we do the same thing as with marks -- we figure out which annotations apply to a node and pass them to a serializer.
Deserializing is harder, because we don't have paths to the nodes at the time we deserialize them. Instead, when we deserialize an annotation, we add the annotation object to a property of the serializer, and we keep a node-to-annotations lookup table. When we're done deserializing, we walk the value's nodes. If we find a node that has an annotation, we update the path of that annotation to include the node. If an annotation spans several nodes, we expand anchor / focus to span the entire range of those nodes.
Have you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn prettier
.)yarn watch
.)Does this fix any issues or need any specific reviewers?
Fixes: #3030
Reviewers: @