add null-guard for insertTextAtRange when marks is undefined #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
ara4n
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jul 8, 2018
t3chguy
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jul 9, 2018
(cherry picked from commit 445faca) Signed-off-by: Michael Telatynski <[email protected]>
|
Thanks @t3chguy! |
justinweiss
pushed a commit
to aha-app/slate
that referenced
this pull request
Feb 6, 2019
z2devil
pushed a commit
to z2devil/slate
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
fixing a recent bug that slipped in during #1875
What's the new behavior?
No error is thrown.
Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn prettier.)yarn watch.)