Fallback to last leaf node when inserting change #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spellcheck/autocorrect is another pain point for now. Does this works for #909 ? It seems to be hard since |
|
Unfortunately, no. But I'll look into it slowly as I get a grasp on how the codebase works. This only affects the changes that occur at the end of the line that would today crash the editor (because DOM offset is larger than leaf). |
|
If facebook/react#11211 was implemented, we'd actually have @blakeembrey this looks great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I swear I found the related issue before I discovered this issue and started working on fixing it, but I can't find it again now.
Before:
After: