Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Refactor rake/rspec setup + drop support for Rails < 4.1 and ruby 1.9.3 #12

Merged
merged 9 commits into from
Nov 18, 2019
Merged

Refactor rake/rspec setup + drop support for Rails < 4.1 and ruby 1.9.3 #12

merged 9 commits into from
Nov 18, 2019

Commits on Apr 1, 2018

  1. Remove .ruby-version file

    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    6477d22 View commit details
    Browse the repository at this point in the history

  2. gemspec: Allow a newer versions of RSpec (3.7 in this case)

    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    c70b85b View commit details
    Browse the repository at this point in the history

  3. Stop supporting rails < 4.1 

    The specs for this version were failing with the following exception:

Mysql2::Error: All parts of a PRIMARY KEY must be NOT NULL; if you need
NULL in a key, use UNIQUE instead:
CREATE TABLE `balloons` (
`id` int(11) DEFAULT NULL auto_increment PRIMARY KEY,
`color` enum('red','gold') DEFAULT 'gold' NOT NULL,
`size` enum('small','medium','large')
) ENGINE=InnoDB
    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    6524e77 View commit details
    Browse the repository at this point in the history

  4. Specs: Use verbose = false instead of overriding $stdout 

    Same effect, but limited to ActiveRecord's logging only
    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    fce8ccf View commit details
    Browse the repository at this point in the history

  5. Disable RSpec's global monkey patching and scope helpers under module 

    Instead of defining all helper methods on Object
    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    6a62e78 View commit details
    Browse the repository at this point in the history

  6. Use ActiveRecord::Rake::DatabaseTasks for the rake tasks 

    This makes it easier to create/drop the databases.

See: https://github.com/rails/rails/blob/v5.0.7/activerecord/lib/active_record/tasks/database_tasks.rb
    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    ae5d083 View commit details
    Browse the repository at this point in the history

  7. Travis CI: Test with newer ruby versions and drop 1.9.3

    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    fbab68f View commit details
    Browse the repository at this point in the history

  8. Travis CI: Setup database via rake

    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    877c230 View commit details
    Browse the repository at this point in the history

  9. Allow 2.5 to fail until Travis CI bug is fixed 

    For more info see:
* travis-ci/travis-ci#8978
* travis-ci/travis-ci#8969
    @mcls
    mcls committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    664aff3 View commit details
    Browse the repository at this point in the history