Merge pull request #3 from Runtus/interval-min-height

fix: cancel the maxHeight type and format the code style
iamzone · Nov 7, 2023 · b25c03a · b25c03a
2 parents 922f647 + 9882299
commit b25c03a
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 37 deletions.
diff --git a/__tests__/plots/static/alphanbet-interval-min-height-transposed.ts b/__tests__/plots/static/alphanbet-interval-min-height-transposed.ts
@@ -11,19 +11,19 @@ export function alphabetIntervalMinHeightTransposed(): G2Spec {
       { genre: 'Shooter', sold: 350 },
       { genre: 'Other', sold: 150 },
     ],
-      encode: {
-          x: "genre",
-          y: "sold",
-          color: "genre"
-      },
-      axis: {
-          x: { animate: false },
-          y: { animate: false }
-      },
-      style: {
-        draggable: true,
-        droppable: true,
-        minHeight: 50
-      }
+    encode: {
+      x: 'genre',
+      y: 'sold',
+      color: 'genre',
+    },
+    axis: {
+      x: { animate: false },
+      y: { animate: false },
+    },
+    style: {
+      draggable: true,
+      droppable: true,
+      minHeight: 50,
+    },
   };
 }
diff --git a/__tests__/plots/static/alphanbet-interval-min-height.ts b/__tests__/plots/static/alphanbet-interval-min-height.ts
@@ -10,19 +10,19 @@ export function alphabetIntervalMinHeight(): G2Spec {
       { genre: 'Shooter', sold: 350 },
       { genre: 'Other', sold: 150 },
     ],
-      encode: {
-          x: "genre",
-          y: "sold",
-          color: "genre"
-      },
-      axis: {
-          x: { animate: false },
-          y: { animate: false }
-      },
-      style: {
-        draggable: true,
-        droppable: true,
-        minHeight: 50
-      }
+    encode: {
+      x: 'genre',
+      y: 'sold',
+      color: 'genre',
+    },
+    axis: {
+      x: { animate: false },
+      y: { animate: false },
+    },
+    style: {
+      draggable: true,
+      droppable: true,
+      minHeight: 50,
+    },
   };
 }
diff --git a/__tests__/plots/static/index.ts b/__tests__/plots/static/index.ts
@@ -4,8 +4,8 @@ export { alphabetIntervalMaxWidth } from './alphabet-interval-max-width';
 export { alphabetIntervalMinWidth } from './alphabet-interval-min-width';
 export { alphabetIntervalMaxWidthTransposed } from './alphabet-interval-max-width-transposed';
 export { alphabetIntervalMinWidthTransposed } from './alphabet-interval-min-width-transposed';
-export { alphabetIntervalMinHeight } from './alphanbet-interval-min-height'
-export { alphabetIntervalMinHeightTransposed } from './alphanbet-interval-min-height-transposed'
+export { alphabetIntervalMinHeight } from './alphanbet-interval-min-height';
+export { alphabetIntervalMinHeightTransposed } from './alphanbet-interval-min-height-transposed';
 export { alphabetIntervalTitle } from './alphabet-interval-title';
 export { alphabetIntervalLabelOverflowHide } from './alphabet-interval-label-overflow-hide';
 export { alphabetIntervalLabelContrastReverse } from './alphabet-interval-label-contrast-reverse';

diff --git a/src/shape/interval/color.ts b/src/shape/interval/color.ts
@@ -73,7 +73,9 @@ export function rect(
       ? clamp(finalHeight, minWidth, maxWidth)
       : clamp(finalHeight, minHeight, Infinity);
     const clampX = tpShape ? finalX : finalX - (clampWidth - finalWidth) / 2;
-    const clampY = tpShape ? finalY - (clampHeight - finalHeight ) / 2 : finalY - (clampHeight - finalHeight);
+    const clampY = tpShape
+      ? finalY - (clampHeight - finalHeight) / 2
+      : finalY - (clampHeight - finalHeight);
 
     return select(document.createElement('rect', {}))
       .style('x', clampX)
@@ -188,7 +190,7 @@ export const Color: SC<ColorOptions> = (options, context) => {
       insetTop,
       minWidth,
       maxWidth,
-      minHeight
+      minHeight,
     };
 
     return (

diff --git a/src/shape/interval/rect.ts b/src/shape/interval/rect.ts
@@ -15,11 +15,6 @@ export type RectOptions = {
    * Minimum height of each interval.
    */
   minHeight?: number;
-
-  /**
-   * Minimum height of each interval.
-   */
-  maxHeight?: number;
 };
 
 /**